feat(editor): Overhaul expression editor modal #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ✨ Initial setup * 👕 Fix lint * ⚡ Extract segments * ⚡ Implement var insertion * 👕 Ignore `.d.cts` * ⚡ Refactor to simplify * ✨ Add brace handler * ✨ Fully replace input and output
#4600) * ✨ Initial adjustments * 🐛 Prevent empty decorations * ⚡ Adjust resolved expression to match param input hint * ✏️ Improve comment * 👕 Remove lint rule * ✏️ Fix typo * ✏️ Fix closing brace * ⚡ Clean up `displayableSegments()`
* 🐛 Fix env var access for FE * 🔥 Remove excess closing bracket * 🚧 Set up TODO * ✏️ Update copy * ⚡ Deny env vars access to FE * 👕 Remove unneeded lint exception * 📘 Remove unneeded typing
* ✏️ Update copy * ⚡ Dynamically delay evaluation resolution * 🔥 Remove unneeded computed property
* 🔥 Remove `ExpressionInput` component * 🔥 Remove Quill * ✏️ Rename i18n key * 🎨 Place border on correct element * 🐛 Handle syntax errors * ⚡ Add sample autocompletions * 🐛 Fix auto-extending behavior
n8n-assistant
bot
added
core
* 🎨 Hide hint on small screen * ⚡ Improve escaping
…4660) * 🎨 Restyle hint * 🎨 Restyle param input hint * 🔥 Remove `e.g.` * ⚡ Tweak delay * 🎨 Restyle output * 🎨 Tweak theme * ✏️ Tweak copy
* 🎨 Change background color * ⚡ Focus on mount * ⚡ Account for preexisting braces on injection * 🐛 Fix `$workflow` showing as not saved * ✏️ Tweak copy * 🐛 Fix readonly focus * ⚡ Focus input on paste * ⚡ Sync inputs with modal * ✏️ Tweak copy
* ⚡ Allow newlines * ⚡ Set cursor at end of content * ⚡ Do not defocus on paste on Chrome
ivov
commented
Nov 28, 2022
ivov
commented
Nov 28, 2022
ivov
commented
Nov 28, 2022
ivov
commented
Nov 28, 2022
ivov
commented
Nov 29, 2022
packages/editor-ui/src/components/ExpressionEditorModal/n8nLanguagePack/index.cjs
Show resolved
Hide resolved
mutdmour
reviewed
Nov 30, 2022
mutdmour
reviewed
Nov 30, 2022
packages/editor-ui/src/components/ExpressionEditorModal/theme.ts
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/ExpressionEditorModal/theme.ts
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/ExpressionEditorModal/resolvable.completions.ts
Show resolved
Hide resolved
packages/editor-ui/src/components/ExpressionEditorModal/ExpressionModalOutput.vue
Show resolved
Hide resolved
packages/editor-ui/src/components/ExpressionEditorModal/ExpressionModalInput.vue
Outdated
Show resolved
Hide resolved
mutdmour
reviewed
Dec 1, 2022
packages/editor-ui/src/components/ExpressionEditorModal/ExpressionModalInput.vue
Outdated
Show resolved
Hide resolved
mutdmour
previously approved these changes
Dec 1, 2022
mutdmour
approved these changes
Dec 1, 2022
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 1, 2022
* master: feat(Postmark Trigger Node): Update credentials so they can be used with the HTTP Request Node (#4790) fix(editor): Remove unnecessary closing tag in CanvasControls (no-changelog) (#4792) feat(Facebook Graph API Node): Update to support api version 15 (#4791) fix(Pipedrive Node): Resolve properties not working fix(editor): Remove excess `isReadOnly` prop (no-changelog) (#4786) fix(core): OAuth2 scope saved to DB fix feat(editor): Overhaul expression editor modal (#4631) test(editor): Intercept credentials save and test request and wait for them in e2e test (#4778) fix(Google Sheets Node): Fix for append operation if no empty rows in sheet
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.